cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: prevent infinite rerendering of DataTable

Open eunjae-lee opened this issue 10 months ago • 2 comments

What does this PR do?

UserListTable is infinitely rendered when a filter value is set. This PR fixes it by fixing the implementation of useFetchMoreOnBottomReached.


https://github.com/user-attachments/assets/64fc1383-ffe1-4e1a-9a29-479568a158d2

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Make sure "fetch more" works
  • Doesn't rerender infinitely when all the rows are already fetched

in

  • organization member list
  • team member list
  • insights routing form responses

Checklist

eunjae-lee avatar Dec 10 '24 14:12 eunjae-lee