cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: No option to install/disconnect app from app detail page

Open asadath1395 opened this issue 1 year ago • 4 comments

What does this PR do?

No option to install/disconnect app from app detail page

  • Fixes #14307

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [x] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [x] I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

https://www.loom.com/share/49e1050b7e1e42e9af6e669b953b4118?sid=0807e556-61a0-4faa-99ea-d4ce9795b8a0

asadath1395 avatar Dec 04 '24 11:12 asadath1395

@asadath1395 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 04 '24 11:12 vercel[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/04/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/04/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/01/25)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Dec 04 '24 11:12 graphite-app[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ❌ Failed (Inspect) Dec 12, 2024 11:33am
calcom-web-canary ❌ Failed (Inspect) Dec 12, 2024 11:33am

vercel[bot] avatar Dec 05 '24 07:12 vercel[bot]

@keithwillcode Can you please assign someone to review this? Thanks

asadath1395 avatar Dec 11 '24 12:12 asadath1395

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jan 01 '25 00:01 github-actions[bot]

@emrysal If you have the bandwidth, could you please review this PR? Thanks

asadath1395 avatar Jan 01 '25 07:01 asadath1395

E2E results are ready!

github-actions[bot] avatar Jan 01 '25 13:01 github-actions[bot]

@PeerRich @anikdhabal I think auto-merge is broken. Can we get this merged today? All i see is everyone trying to run the pipeline and forgetting to come back 😄

asadath1395 avatar Jan 10 '25 12:01 asadath1395

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Feb 05 '25 00:02 github-actions[bot]

@PeerRich Can we get this merged?

asadath1395 avatar Feb 07 '25 08:02 asadath1395

@PeerRich Can we get this merged?

hey the E2E tests are failing on this

retrogtx avatar Feb 09 '25 05:02 retrogtx

@asadath1395 are you still working on this , tests are failing

TusharBhatt1 avatar Feb 14 '25 05:02 TusharBhatt1

@asadath1395 are you still working on this , tests are failing

it's the E2E failure I think, Anik is working on this made a PR for the same yesterday

retrogtx avatar Feb 14 '25 06:02 retrogtx

@anikdhabal Are you able to reproduce the failing test locally? Since you fixed something related to analytics app store installation recently, I can't seem to reproduce that, it works fine in my machine.

asadath1395 avatar Feb 24 '25 16:02 asadath1395