cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: Updated city-timezones to support Kyiv

Open AlexHladin opened this issue 1 year ago • 8 comments

What does this PR do?

This PR fixes the incorrect timezone name for Kyiv.

  • Fixes #12224 (GitHub issue number)

Mandatory Tasks (DO NOT REMOVE)

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [ ] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • [ ] I confirm automated tests are in place that prove my fix is effective or that my feature works.

AlexHladin avatar Oct 18 '24 10:10 AlexHladin

@AlexHladin is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 18 '24 10:10 vercel[bot]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Updated city-timezones to support Kyiv". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

github-actions[bot] avatar Oct 18 '24 10:10 github-actions[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (10/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/18/24)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Oct 18 '24 10:10 graphite-app[bot]

E2E results are ready!

github-actions[bot] avatar Oct 24 '24 16:10 github-actions[bot]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteCI
Critical CVE npm/dompurify@=2.3.3 ⚠︎
Possible typosquat attack npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/dompurify@=2.3.3
  • @SocketSecurity ignore npm/[email protected]

socket-security[bot] avatar Nov 14 '24 09:11 socket-security[bot]

Hey @keithwillcode @zomars @PeerRich The PR is passed unit tests and types check. Could you please review and merge PR?

AlexHladin avatar Nov 30 '24 13:11 AlexHladin

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ❌ Failed (Inspect) Dec 10, 2024 4:51pm
calcom-web-canary ❌ Failed (Inspect) Dec 10, 2024 4:51pm

vercel[bot] avatar Dec 04 '24 19:12 vercel[bot]

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@formkit/[email protected] None 0 35.4 kB justin-schroeder
npm/@types/[email protected] None 0 3.37 kB types
npm/@types/[email protected] None 0 868 kB types
npm/@types/[email protected] None 0 3.38 kB types
npm/@types/[email protected] 🔁 npm/@types/[email protected], npm/@types/[email protected] None 0 1.63 MB types
npm/[email protected] None 0 23.6 kB jedwatson
npm/[email protected] None 0 669 kB kewisch

🚮 Removed packages: npm/@axiomhq/[email protected], npm/@calcom/[email protected], npm/@calcom/[email protected], npm/@golevelup/[email protected], npm/@microsoft/[email protected], npm/@nest-lab/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@nestjs/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar Jan 14 '25 15:01 socket-security[bot]

Closing this PR as it is doing way more that describes. Feel free to re-open with only the relevant parts. Also feel free to open another one with type improvements if necessary.

zomars avatar Jan 14 '25 15:01 zomars

@AlexHladin Hey Alex, there's lots of type improvements going on in this PR. While we massively appreciate it, it makes it very difficult to review. Please open a fresh PR and request me a review.

hbjORbj avatar Jan 14 '25 15:01 hbjORbj

@hbjORbj @zomars types changes are required, because react-timezone requires it. I can't skip types improvement things.

AlexHladin avatar Jan 14 '25 15:01 AlexHladin