cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: incorrect encryption string instructions

Open lujstn opened this issue 1 year ago • 4 comments

What does this PR do?

As outlined in https://github.com/calcom/cal.com/issues/13290, any new calcom user following the .env example is unable to perform any administrative function as 2FA is required.

Because "latin1" is specified as the encryption/decryption method in lib/crypto.ts, using a base64 encoded string (as is currently suggested) results in a 44 length string, which breaks the 2FA process.

A cleaner solution would be to update crypto.ts directly, but this was already rejected in https://github.com/calcom/cal.com/pull/13484 in favour of the ongoing refactor in https://github.com/calcom/cal.com/pull/12698. This PR is a temporary fix until the larger refactor has been completed.

  • Fixes #13290
  • Fixes CAL-3060

Mandatory Tasks

  • [x] I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • [x] I have added a Docs issue here if this PR makes changes that would require a documentation change
  • [x] I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

lujstn avatar May 17 '24 00:05 lujstn

@lucasjohnston is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 17 '24 00:05 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar May 17 '24 00:05 github-actions[bot]

Graphite Automations

"Add community label" took an action on this PR • (05/17/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar May 17 '24 00:05 graphite-app[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 17 '24 00:05 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jun 02 '24 00:06 github-actions[bot]

fixed by this one https://github.com/calcom/cal.com/pull/12698.

anikdhabal avatar Jun 29 '24 07:06 anikdhabal