cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: Add {first name} variable to Organizer & Scheduler custom event…

Open Amit91848 opened this issue 1 year ago • 7 comments

What does this PR do?

Fixes #13974

https://github.com/calcom/cal.com/assets/74371312/b039f9d2-e521-458c-acf6-b638ed7464ad

Type of change

  • New feature (non-breaking change which adds functionality)

Mandatory Tasks

  • [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Amit91848 avatar Mar 20 '24 13:03 Amit91848

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 20 '24 13:03 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Mar 20 '24 13:03 github-actions[bot]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/20/24)

1 label was added to this PR based on Keith Williams's automation.

graphite-app[bot] avatar Mar 20 '24 13:03 graphite-app[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/settings/organizations/platform/oauth-clients 264.75 KB 493.32 KB 140.95%
/settings/organizations/platform/oauth-clients/create 264.93 KB 493.5 KB 141.00%

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/availability 464.73 KB 693.3 KB 198.09% (🟡 +10.59%)
/event-types/[type] 435.7 KB 664.27 KB 189.79% (🟢 -0.16%)
/settings/admin/lockedSMS/UsersTable 78.89 KB 307.46 KB 87.85% (🟢 -0.18%)
/settings/admin/lockedSMS/lockedSMSView 118.56 KB 347.13 KB 99.18% (🟢 -0.20%)
/settings/admin/oAuth/oAuthView 94.97 KB 323.54 KB 92.44% (🟢 -0.19%)
/settings/admin/orgMigrations/_OrgMigrationLayout 250.58 KB 479.16 KB 136.90% (🟢 -0.18%)
/settings/organizations/[id]/about 155.73 KB 384.3 KB 109.80% (🟢 -0.53%)
/settings/organizations/[id]/add-teams 155.72 KB 384.29 KB 109.80% (🟢 -0.53%)
/settings/organizations/dsync 331.47 KB 560.04 KB 160.01% (🟡 +10.54%)
/settings/organizations/members 430.56 KB 659.13 KB 188.32% (🟡 +8.75%)
/settings/organizations/new 155.74 KB 384.31 KB 109.80% (🟢 -0.53%)
/settings/organizations/teams/other/[id]/profile 468.65 KB 697.22 KB 199.21% (🟢 -0.19%)
/settings/teams/[id]/profile 469.48 KB 698.05 KB 199.44% (🟢 -0.18%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Mar 20 '24 13:03 github-actions[bot]

Should we only show those variables when split full name is checked? Or should we add some helper text that it will only work when you have set it to true?

Amit91848 avatar Apr 20 '24 11:04 Amit91848

Should we only show those variables when split full name is checked? Or should we add some helper text that it will only work when you have set it to true?

It would be best to only show them if split name is enabled

CarinaWolli avatar Apr 26 '24 19:04 CarinaWolli

Made changes @CarinaWolli. Also the issue was closed, is this still relevant?

Amit91848 avatar Apr 27 '24 07:04 Amit91848

I reopened the issue, I think it's still nice to have

CarinaWolli avatar Apr 29 '24 14:04 CarinaWolli