calcom
feat: invite emails from assignment
What does this PR do?
Fixes #13532 /claim #13532
ps: have disabled the pending users in dropdown, because pending users dont have their Availability set-up.
@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
- Is it hard to allow adding existing team members not only by name but also by e-mail? I think that if we can add new members by e-mail, we should allow searching existing ones by e-mail too.
- I think under "Team" heading above dropdown to "Add attendees" should be an explanation - "Add existing team members by name or e-mail or invite new team members using e-mail" because otherwise this feature is hidden from users.
@PeerRich do you agree?
- Is it hard to allow adding existing team members not only by name but also by e-mail? I think that if we can add new members by e-mail, we should allow searching existing ones by e-mail too.
- I think under "Team" heading above dropdown to "Add attendees" should be an explanation - "Add existing team members by name or e-mail or invite new team members using e-mail" because otherwise this feature is hidden from users.
@PeerRich do you agree?
What if under the user dropdown link we add an option "Invite new team members" or something similar that opens the member invite dialog. That way we can reuse the logic or email or username look up and role assignment. I think the only thing that needs to be added would be to auto assign them to the team but not included in the availability query (might already exist?)
@CarinaWolli are we sure we want to go forward with this approach i mean @joeauyeung suggestion was pretty good too, and would also save us a lot of unnecessary complication too,(adding spinners and all)
What if under the user dropdown link we add an option "Invite new team members" or something similar that opens the member invite dialog. That way we can reuse the logic or email or username look up and role assignment. I think the only thing that needs to be added would be to auto assign them to the team but not included in the availability query (might already exist?)
Sorry, I totally missed that comment. I do think we should make it more clear, like @supalarry said, right now this feature would be hidden for users. @joeauyeung where would you put the option to 'Invite new team members'? I think we want to avoid to add anything below the list of hosts, as this list can get long
Maybe @ciaranha can give some input here how to best do that ui/ux-wise
@SomayChauhan Is this the same as https://github.com/calcom/cal.com/pull/14185?
yes!!, closing this in favour of https://github.com/calcom/cal.com/pull/14185