cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: Added disabled prop in save button

Open soham2k06 opened this issue 2 years ago • 3 comments

File: EventTypeSingleLayout.tsx If no input field is changed then 'save' button will be disabled.

What does this PR do?

If no input field is changed then 'save' button will be disabled.

Fixes # (issue)

It fixes the bug where used could click save button even if no field is updated in event. It reduces fetch requests.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Mandatory Tasks

  • [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

soham2k06 avatar Jan 09 '24 10:01 soham2k06

@soham2k06 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 09 '24 10:01 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Jan 09 '24 10:01 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Jan 09 '24 10:01 github-actions[bot]

This PR https://github.com/calcom/cal.com/pull/13292#pullrequestreview-1875797381 should fix the issue

Udit-takkar avatar Feb 13 '24 06:02 Udit-takkar