cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: implement Flagsmith feature flags

Open ibex088 opened this issue 2 years ago • 7 comments

What does this PR do?

Fixes #12598

used flagsmith which is an open-source Feature Flag Service that we can self-host as well, (currently using their hosted service)

https://www.loom.com/share/d91d727549f74f2984a3327e00265878

Take a look and let me know if it aligns with the requirements, and i'll be happy to work on it further.

ibex088 avatar Jan 03 '24 09:01 ibex088

@SomayChauhan is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 03 '24 09:01 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Jan 03 '24 09:01 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Jan 03 '24 09:01 github-actions[bot]

@zomars do we wanna use this instead of our own?

PeerRich avatar Jan 08 '24 13:01 PeerRich

understood, will start working on it further then!!!

ibex088 avatar Jan 08 '24 16:01 ibex088

@zomars do we wanna use this instead of our own?

As @keithwillcode mentioned. We don't want to rely on third parties for this. It would be nice to opt-in if a hoster wants it. But it's not quite there in the current state.

zomars avatar Jan 08 '24 18:01 zomars

@keithwillcode @PeerRich @zomars can you take a look to quickly setup and test:

  • set FLAGSMITH_ENVIRONMENT_ID=QLCiG9qqCJRfN34e6BAwjW in .env
  • go to http://13.233.201.155:8000/
  • login with [email protected] and PasswordPassword@111
  • and test on maybe insights page
  • kinda have to login to set traits (email and orgID)

if the FLAGSMITH_ENVIRONMENT_ID is not set it fetches flags from our Features table, otherwise it will fetch flags form flagsmith and save them in our existing FeatureProvider

ibex088 avatar Jan 12 '24 13:01 ibex088

Hey there, there is a merge conflict, can you take a look?

github-actions[bot] avatar Jan 23 '24 05:01 github-actions[bot]

closing in favour of #13420

ibex088 avatar Jan 26 '24 12:01 ibex088