cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: Creating New Bookings From Already Rescheduled Links

Open joeauyeung opened this issue 2 years ago • 6 comments

What does this PR do?

This PR prevents new bookings from being created when the same reschedule link is used multiple times.

Fixes #12922

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Create a booking
  • Reschedule a booking with link #1
  • Try rescheduling with the same booking link
    • It should bring you back to the success page of the most recent booking

Mandatory Tasks

  • [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

joeauyeung avatar Dec 22 '23 04:12 joeauyeung

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ❌ Failed (Inspect) Dec 22, 2023 7:59pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 7:59pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 7:59pm
cal ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 7:59pm
cal-demo ⬜️ Ignored (Inspect) Dec 22, 2023 7:59pm
qa ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 7:59pm
ui ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 7:59pm

vercel[bot] avatar Dec 22 '23 04:12 vercel[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Dec 22 '23 04:12 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Dec 22 '23 04:12 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jan 06 '24 00:01 github-actions[bot]

Hey there, there is a merge conflict, can you take a look?

github-actions[bot] avatar Jan 23 '24 05:01 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Feb 07 '24 00:02 github-actions[bot]

Closing this until we have the real need to come back and address it permanently. Currently, the bug is not possible to reproduce because we now return a 404. Feel free to reopen this PR when/if the issue is taken back up.

keithwillcode avatar Feb 20 '24 19:02 keithwillcode