upgrade icon indicating copy to clipboard operation
upgrade copied to clipboard

Some migrations not applied / not defined

Open smarek opened this issue 5 years ago • 5 comments

  • Table Table->newEntity() should be migrated to Table->newEmptyEntity(), validating that newEntity() did not originally contain any arguments / data for entity creation
  • Paginator $this->Paginator->counter(['format' => __('format text')]) should be migrated to $this->Paginator->counter(__('format text'))
  • Form public function buildValidator(Event $event, Validator $validator, $name) should be migrated to public function validationDefault(Validator $validator): Validator if the method validationDefault is not yet defined
  • Form public function validate(array $data) should be migrated to public function validate(array $data): bool
  • Form protected function _buildSchema(Schema $schema) should be migrated to protected function _buildSchema(Schema $schema): Schema
  • Form public function getData($field = null) should get migrated to public function getData(?string $field = null)
        $this->paginate = [
            'order' => ['SomeTable.column'],
        ];

should be migrated to

        $this->paginate = [
            'order' => ['SomeTable.column' => 'asc'],
        ];

thus specifically providing order, if it was not provided before

smarek avatar Jul 09 '20 09:07 smarek

Not all of these are doable with rector, but I can update the 40 rules for the ones we can automatically update.

markstory avatar Jul 14 '20 17:07 markstory

@markstory I've checked them briefle and all can be automated.

TomasVotruba avatar Jul 16 '20 08:07 TomasVotruba

Thanks for letting us know about that @TomasVotruba I'll circle back on this and figure out how to do the other changes.

markstory avatar Jul 17 '20 01:07 markstory