upgrade
upgrade copied to clipboard
Some migrations not applied / not defined
-
Table
Table->newEntity()should be migrated toTable->newEmptyEntity(), validating thatnewEntity()did not originally contain any arguments / data for entity creation -
Paginator
$this->Paginator->counter(['format' => __('format text')])should be migrated to$this->Paginator->counter(__('format text')) -
Form
public function buildValidator(Event $event, Validator $validator, $name)should be migrated topublic function validationDefault(Validator $validator): Validatorif the methodvalidationDefaultis not yet defined -
Form
public function validate(array $data)should be migrated topublic function validate(array $data): bool -
Form
protected function _buildSchema(Schema $schema)should be migrated toprotected function _buildSchema(Schema $schema): Schema -
Form
public function getData($field = null)should get migrated topublic function getData(?string $field = null)
$this->paginate = [
'order' => ['SomeTable.column'],
];
should be migrated to
$this->paginate = [
'order' => ['SomeTable.column' => 'asc'],
];
thus specifically providing order, if it was not provided before
Not all of these are doable with rector, but I can update the 40 rules for the ones we can automatically update.
@markstory I've checked them briefle and all can be automated.
Thanks for letting us know about that @TomasVotruba I'll circle back on this and figure out how to do the other changes.