nirvana icon indicating copy to clipboard operation
nirvana copied to clipboard

Log package: support logging to file

Open caitong93 opened this issue 7 years ago • 7 comments

/kind feature

caitong93 avatar Oct 26 '18 10:10 caitong93

Please implement it and file a PR.

kdada avatar Oct 26 '18 10:10 kdada

Hi, I am a student from Shanghai Jiao Tong University and will be a Caiclouder in the next year. I am interested in the project :-) I am glad to implement the feature as my first contribution when I am free in the next month.

While, I have a question about our logger package. There are many libraries about loggers then I am not sure why we implemented the std logger on our own. Is there any thing I missed about it? I'd appreciate it if you could resolve my doubts.

gaocegege avatar Dec 18 '18 12:12 gaocegege

Actually the biggest problem is there are so many log libraries. So we implement a common log interface (glog-like) to constraint our codes. Then you can replace the implementation of logger with any other packages which you like.

In the other hand, Nirvana should have its own log packages for common usages. e.g. std, file.

kdada avatar Dec 19 '18 12:12 kdada

@gaocegege go ahead. You can write your design doc in this issue.

kdada avatar Dec 19 '18 12:12 kdada

@gaocegege hello,what is the status of this issue?

volgariver6 avatar Sep 21 '19 13:09 volgariver6

@lauber00 There is no implementation of file logger now. If you could implement it, we'll very appreciate it.

kdada avatar Oct 08 '19 04:10 kdada

/assign

gaocegege avatar Nov 25 '19 10:11 gaocegege