node-webkit-agent icon indicating copy to clipboard operation
node-webkit-agent copied to clipboard
verified publisher icon c4milo

Installation fails with node v0.12.0

Open maxmil7 opened this issue 10 years ago • 12 comments

npm install webkit-devtools-agent /

[email protected] install /Users/mgawande/Desktop/src/scratch/node_modules/webkit-devtools-agent/node_modules/ws (node-gyp rebuild 2> builderror.log) || (exit 0)

CXX(target) Release/obj.target/bufferutil/src/bufferutil.o

[email protected] install /Users/mgawande/Desktop/src/scratch/node_modules/webkit-devtools-agent node-gyp rebuild

child_process: customFds option is deprecated, use stdio instead. CXX(target) Release/obj.target/profiler/src/cpu_profiler.o In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:19:57: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle<Value> GetProfilesCount(const Arguments& args); ^~~~~~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:20:51: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle<Value> GetProfile(const Arguments& args); ^~~~~~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:21:52: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle<Value> FindProfile(const Arguments& args); ^~~~~~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:22:55: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle<Value> StartProfiling(const Arguments& args); ^~~~~~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:23:54: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle<Value> StopProfiling(const Arguments& args); ^~~~~~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:24:58: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle<Value> DeleteAllProfiles(const Arguments& args); ^~~~~~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:2: ../src/profile.h:16:61: error: unknown type name 'AccessorInfo' static Handle<Value> GetUid(Local<String> property, const AccessorInfo& info); ^ ../src/profile.h:17:63: error: unknown type name 'AccessorInfo' static Handle<Value> GetTitle(Local<String> property, const AccessorInfo& info); ^ ../src/profile.h:18:65: error: unknown type name 'AccessorInfo' static Handle<Value> GetTopRoot(Local<String> property, const AccessorInfo& info); ^ ../src/profile.h:19:68: error: unknown type name 'AccessorInfo' static Handle<Value> GetBottomRoot(Local<String> property, const AccessorInfo& info); ^ ../src/profile.h:20:37: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle<Value> Delete(const Arguments& args); ^~~~~~~~~ v8::internal::Arguments /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ ../src/cpu_profiler.cc:8:21: error: calling a protected constructor of class 'v8::HandleScope' HandleScope scope; ^ /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:816:13: note: declared protected here V8_INLINE HandleScope() {} ^ ../src/cpu_profiler.cc:10:62: error: 'New' is a private member of 'v8::PersistentBasev8::ObjectTemplate' cpu_profiler_template_ = Persistent<ObjectTemplate>::New(ObjectTemplate::New()); ^ /Users/mgawande/.node-gyp/0.12.0/deps/v8/include/v8.h:572:23: note: declared private here V8_INLINE static T* New(Isolate* isolate, T* that); ^ ../src/cpu_profiler.cc:10:34: error: too few arguments to function call, expected 2, have 1; did you mean 'Profile::New'? cpu_profiler_template_ = Persistent<ObjectTemplate>::New(ObjectTemplate::New()); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Profile::New ../src/profile.h:13:24: note: 'Profile::New' declared here static Handle<Value> New(const CpuProfile* profile); ^ ../src/cpu_profiler.cc:11:31: error: member reference type 'Persistentv8::ObjectTemplate' is not a pointer; maybe you meant to use '.'? cpu_profiler_template_->SetInternalFieldCount(1); ~~~~~~~~~~~~~~~~~~~~~~^~ . ../src/cpu_profiler.cc:11:33: error: no member named 'SetInternalFieldCount' in 'v8::Persistent<v8::ObjectTemplate, v8::NonCopyablePersistentTraitsv8::ObjectTemplate >' cpu_profiler_template_->SetInternalFieldCount(1); ~~~~~~~~~~~~~~~~~~~~~~ ^ ../src/cpu_profiler.cc:13:62: error: member reference type 'Persistentv8::ObjectTemplate' is not a pointer; maybe you meant to use '.'? Local<Object> cpuProfilerObj = cpu_profiler_template_->NewInstance(); ~~~~~~~~~~~~~~~~~~~~~~^~ . ../src/cpu_profiler.cc:13:64: error: no member named 'NewInstance' in 'v8::Persistent<v8::ObjectTemplate, v8::NonCopyablePersistentTraitsv8::ObjectTemplate >' Local<Object> cpuProfilerObj = cpu_profiler_template_->NewInstance(); ~~~~~~~~~~~~~~~~~~~~~~ ^ ../src/cpu_profiler.cc:15:9: error: no matching function for call to 'NODE_SET_METHOD' NODE_SET_METHOD(cpuProfilerObj, "getProfilesCount", CpuProfiler::GetProfilesCount); ^~~~~~~~~~~~~~~ /Users/mgawande/.node-gyp/0.12.0/src/node.h:240:25: note: expanded from macro 'NODE_SET_METHOD'

define NODE_SET_METHOD node::NODE_SET_METHOD

                    ^~~~~~~~~~~~~~~~~~~~~

/Users/mgawande/.node-gyp/0.12.0/src/node.h:228:13: note: candidate function [with TypeName = v8::Localv8::Object] not viable: no known conversion from 'Handlev8::Value (const v8::internal::Arguments &)' to 'v8::FunctionCallback' (aka 'void ()(const FunctionCallbackInfov8::Value &)') for 3rd argument inline void NODE_SET_METHOD(const TypeName& recv, ^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated. make: ** [Release/obj.target/profiler/src/cpu_profiler.o] Error 1 gyp ERR! build error gyp ERR! stack Error: make failed with exit code: 2 gyp ERR! stack at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23) gyp ERR! stack at ChildProcess.emit (events.js:110:17) gyp ERR! stack at Process.ChildProcess._handle.onexit (child_process.js:1067:12) gyp ERR! System Darwin 13.4.0 gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" gyp ERR! cwd /Users/mgawande/Desktop/src/scratch/node_modules/webkit-devtools-agent gyp ERR! node -v v0.12.0 gyp ERR! node-gyp -v v1.0.2 gyp ERR! not ok npm ERR! Darwin 13.4.0 npm ERR! argv "node" "/usr/local/bin/npm" "install" "webkit-devtools-agent" npm ERR! node v0.12.0 npm ERR! npm v2.5.1 npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: node-gyp rebuild npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the [email protected] install script 'node-gyp rebuild'. npm ERR! This is most likely a problem with the webkit-devtools-agent package, npm ERR! not with npm itself. npm ERR! Tell the author that this fails on your system: npm ERR! node-gyp rebuild npm ERR! You can get their info via: npm ERR! npm owner ls webkit-devtools-agent npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request: npm ERR! /Users/mgawande/Desktop/src/scratch/npm-debug.log

maxmil7 avatar Feb 18 '15 00:02 maxmil7

yes, I need to catch up now. Thanks for the issue report.

c4milo avatar Feb 18 '15 00:02 c4milo

+1

macinjosh32 avatar Mar 11 '15 05:03 macinjosh32

This is being addressed in https://github.com/c4milo/node-webkit-agent/pull/79

c4milo avatar Mar 11 '15 17:03 c4milo

https://github.com/iojs/io.js/issues/456

c4milo avatar Mar 11 '15 20:03 c4milo

+1

Selvatico avatar Mar 15 '15 22:03 Selvatico

Addressed by https://github.com/c4milo/node-webkit-agent/pull/79, CPU profiling is not working yet though.

c4milo avatar Apr 02 '15 23:04 c4milo

Do you expect there will be movement on this issue any time soon? I like node-webkit-agent and would feel sad to switch, but this is a blocker for us upgrading to Node v0.12.

macinjosh32 avatar May 04 '15 13:05 macinjosh32

@macinjosh32 master branch has a working version for Node v0.12.x. Although, there wouldn't be CPU profiler, it is the last piece missing to get full support for 0.12.x.

c4milo avatar Jun 16 '15 17:06 c4milo

using 0.12.5 version of node -> npm install [email protected] gives the below error

[email protected] install /Users/shegde6/nodeapps/SampleApp/node_modules/webkit-devtools-agent/node_modules/ws (node-gyp rebuild 2> builderror.log) || (exit 0)

CXX(target) Release/obj.target/bufferutil/src/bufferutil.o

[email protected] install /Users/shegde6/nodeapps/SampleApp/node_modules/webkit-devtools-agent node-gyp rebuild

CXX(target) Release/obj.target/profiler/src/cpu_profiler.o In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:19:57: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle<Value> GetProfilesCount(const Arguments& args); ^~~~~~~~~ v8::internal::Arguments /Users/shegde6/.node-gyp/0.12.5/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:20:51: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle<Value> GetProfile(const Arguments& args); ^~~~~~~~~ v8::internal::Arguments /Users/shegde6/.node-gyp/0.12.5/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; ^ In file included from ../src/cpu_profiler.cc:1: ../src/cpu_profiler.h:21:52: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'? static Handle<Value> FindProfile(const Arguments& args); ^~~~~~~~~ v8::internal::Arguments /Users/shegde6/.node-gyp/0.12.5/deps/v8/include/v8.h:127:7: note: 'v8::internal::Arguments' declared here class Arguments; .............................................. /Users/shegde6/.node-gyp/0.12.5/src/node.h:228:13: note: candidate function [with TypeName = v8::Localv8::Object] not viable: no known conversion from 'Handlev8::Value (const v8::internal::Arguments &)' to 'v8::FunctionCallback' (aka 'void ()(const FunctionCallbackInfov8::Value &)') for 3rd argument inline void NODE_SET_METHOD(const TypeName& recv, ^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated. make: ** [Release/obj.target/profiler/src/cpu_profiler.o] Error 1 gyp ERR! build error gyp ERR! stack Error: make failed with exit code: 2

sandeshhegde83 avatar Jul 05 '15 23:07 sandeshhegde83

@sandeshhegde83, did you ever resolve this? I'm running into the exact same issue, so if there is a known solution it would be great if you could share it :+1:

tvervest avatar Oct 15 '15 22:10 tvervest

I'm sorry you guys are running into these issues. Unfortunately, I haven't found time to work on this, but I would be happy to help if anyone of you want to tackle this problem.

c4milo avatar Oct 16 '15 14:10 c4milo

+1

JBustin avatar Aug 22 '16 09:08 JBustin