tokenizer icon indicating copy to clipboard operation
tokenizer copied to clipboard

Update to Go 1.22 and stretchr/testify 1.9.0

Open stone-z opened this issue 1 year ago • 6 comments

I noticed the latest releases (all past 1.4.0) weren't listed in the Go package index (ref).

I'm honestly not sure if this is the cause of that issue, but since 1.13 is quite old I figured it was worth the update anyway.

stone-z avatar Sep 26 '24 19:09 stone-z

Just for visibility, ping @bzick

stone-z avatar Oct 07 '24 16:10 stone-z

Thank you for MR. I agree that 1.13 is already outdated, but is it really worth updating straight to 1.23? Most of my projects can’t update to 1.23 and are still running on 1.20-1.22. I mean, 1.23 is still too recent. Maybe it’s worth considering a version that came out two years ago (suggestion)?

~~And what are the reasons for updating?~~ (got it)

bzick avatar Oct 08 '24 19:10 bzick

And thank you that you notice what latest releases weren't listed in the Go package index :raised_hands:

bzick avatar Oct 08 '24 19:10 bzick

About why latest releases weren't listed. My fault. I named versions wrang. e.g. I named 1.4.4 but I should have named v1.4.4. I created v1.4.5 and everything OK now.

bzick avatar Oct 08 '24 19:10 bzick

Sure, Go 1.22 could work also. 1.21 will lose support in February, 1.22 would get updates until next August. I just went to 1.23 since it would be the longest supported. ~Let me know and I can change to 1.22~ I updated the PR so it is Go 1.22 instead :slightly_smiling_face:

stone-z avatar Oct 08 '24 19:10 stone-z

The go directive indicates "the minimum version of Go required to use this module" (see Go Modules Reference: go directive). There is no point in increasing it if not for using newer language features.

And this is also true for the require directive, which indicates "the minimum required version of a given module dependency" (see Go Modules Reference: require directive). Except if we are affected by a bug found in previous versions of testify or if we need newer features, I don't see a reason to increase this requirement.

The indirect dependencies can be easily added to go.mod by running go mod tidy (when targeting go 1.17 and above) without the need for updating them.

n-peugnet avatar Jan 14 '25 23:01 n-peugnet