wit-bindgen icon indicating copy to clipboard operation
wit-bindgen copied to clipboard
verified publisher icon bytecodealliance

refactor(*): move anonymous type definition to core

Open Mossaka opened this issue 2 years ago • 2 comments

This PR moves the define_anonymous_type in C to the core crate, as I believe this is a common pattern in all wit binding languages generators. The benefit of this refactoring work is that language generator does not need to decide which types are anonymous and that is handled by the trait function itself.

CC @alexcrichton

Mossaka avatar Nov 17 '23 00:11 Mossaka

It seems like this PR needs a huge rebase. @alexcrichton any suggestions if we should proceed with this refactoring?

Mossaka avatar Apr 30 '24 18:04 Mossaka

Oh dear I apologize I think github doesn't send out notifications for when a PR moves from draft to ready state, so I never saw this after it switched states. I think this is still reasonable to land though if you'd like to rebase!

alexcrichton avatar May 02 '24 17:05 alexcrichton

@alexcrichton okay I finally found some time to rebase this PR. it's ready for review.

Mossaka avatar May 17 '24 22:05 Mossaka