wit-bindgen icon indicating copy to clipboard operation
wit-bindgen copied to clipboard

Implement the new canonical ABI

Open alexcrichton opened this issue 3 years ago • 1 comments

I've started sending PRs to do this, but I figured it'd also be a good thing to write things down:

(I'll probably add to this over time as I remember things)

alexcrichton avatar Apr 20 '22 16:04 alexcrichton

Ok I think all the major pieces that can be done now are largely done. The remaining bits sort of need questions and topics on https://github.com/bytecodealliance/wit-bindgen/issues/214 to be settled first. For example post-return-style things aren't done but functions aren't guaranteed to have a post-return so it doesn't make sense for the host generators to implement something with post-return as-is.

alexcrichton avatar May 10 '22 18:05 alexcrichton

I'm going to close this in favor of https://github.com/bytecodealliance/wit-bindgen/issues/314 since the remaining few items here and there that need to be covered by hosts I think require deeper refactorings to fully address or they're inconsequential to not really matter a whole lot.

alexcrichton avatar Sep 14 '22 16:09 alexcrichton

@alexcrichton I have a question regarding (since all the 'favored' issues are closed):

Enable mutability in Rust traits generated for in-wasm since recursive entry is now prohibited

wit-bindgen version 0.24.0 still generates x(&self) signature in traits. Is this going to change in the future.

dbaeumer avatar Apr 22 '24 15:04 dbaeumer

It can theoretically yeah but it would be a bit of a nontrivial lift. I didn't handle that during this whole transition due to the complexity involved, but I forgot to open another tracking issue. If you're up for it would you be ok opening a new issue for it?

alexcrichton avatar Apr 22 '24 18:04 alexcrichton