wasmtime icon indicating copy to clipboard operation
wasmtime copied to clipboard
verified publisher icon bytecodealliance

x64: Add native lowering for scalar `fma`

Open afonso360 opened this issue 3 years ago • 0 comments

👋 Hey

This PR adds a lowering for scalar fma for x64. Additionally we enable this operation in the CLIF Fuzzer.

cc: @abrown

afonso360 avatar Jul 27 '22 08:07 afonso360

This PR has unfortunately gone stale, but I'd like to not lose track of it. @afonso360, could you give it a rebase?

jameysharp avatar Aug 11 '22 00:08 jameysharp

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

github-actions[bot] avatar Aug 11 '22 14:08 github-actions[bot]

Changes with the last rebase:

  • We now query the use_fma flag to lower FMA extension instructions
  • Added some compile tests for both the libcall and inst case

afonso360 avatar Aug 11 '22 14:08 afonso360

CI failures seem spurious

afonso360 avatar Aug 11 '22 16:08 afonso360

CI failures are because today's release of Rust 1.63 reports a new warning. #4691 is merged fixing that, so please rebase and then hopefully CI will pass.

jameysharp avatar Aug 11 '22 18:08 jameysharp