wasmtime icon indicating copy to clipboard operation
wasmtime copied to clipboard

Add test for filestat_get for stdio

Open sakarias88 opened this issue 5 years ago • 4 comments

Adding tests as discussed in issue #2515.

sakarias88 avatar Dec 18 '20 13:12 sakarias88

@pchickey

sakarias88 avatar Dec 18 '20 13:12 sakarias88

Subscribe to Label Action

cc @kubkon

This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

  • kubkon: wasi

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

github-actions[bot] avatar Dec 18 '20 13:12 github-actions[bot]

We will fix the CI failures once we get our hands on a windows machine.

sakarias88 avatar Dec 18 '20 14:12 sakarias88

"Fixing up" fstat for Windows brought a question. It seems that the fstat implementation for Windows returns a lot of OS-specific information causing a WASI fstat call to behave differently depending on host OS. I thought the intention was that fstat for example was supposed to return information from a "WASI" perspective. I.e. for example the inode number would be an "emulated" inode number that is the same on both Unix and Windows hosts (which is not the case in Wasmtime currently but it is in Wasmer)? Not that doing logic on the inode number is very likely but anyway 😄

abbec avatar Jan 14 '21 13:01 abbec

This is pretty dated at this point so I'm going to close this. Lots about WASI has additionally changed in the intervening time. To the extent that it's nice to have more tests I think it'd still be good to add tests for this, but that's probably best done in a fresh PR.

alexcrichton avatar Mar 14 '24 17:03 alexcrichton