regalloc.rs
regalloc.rs copied to clipboard
Unconventional naming convention
Several files in the repository use names which are unconventional in Rust:
fn is_Unavail(&self) -> bool {
let mut vlrEquivClassesUF =
etc.
These would ordinarily get warnings, however the warnings are disabled:
#![allow(non_camel_case_types)]
#![allow(non_snake_case)]
Naming conventions are subjective, and in isolation, the style used here is reasonable. However, this crate is meant to be used by Cranelift and by a broader ecosystem of Rust libraries, and it adds friction for people who work across repositories if multiple naming conventions are in use.