javy icon indicating copy to clipboard operation
javy copied to clipboard

Published Windows executables should end in exe and use a zip format

Open jeffcharles opened this issue 2 years ago • 1 comments

Operating system: Windows Processor architecture: N/A Rust version: N/A Javy version: v1.1.2

Problem

At the moment, the build assets workflow creates a Windows executable but drops the required exe extension and uses gzip instead of zip for compressing the executable. The exe extension is required on Windows for all executable binaries and Windows does not have a built in way to decompress gzip files but does have a built in way to decompress zip files.

Error Message and Context

Technically someone could install gzip and manually rename the executable file to add the exe extension, but we should just produce executables in the correct format.

jeffcharles avatar Jul 17 '23 15:07 jeffcharles

It's worth noting that the javy-cli NPM package currently assumes there will be a .gz file available for Windows on the release and uses gunzip to decompress the response body from downloading that file. It's also worth noting that the presence of an .exe extension in the URL for the Windows asset will also break the NPM package's download logic.

jeffcharles avatar Jul 18 '23 16:07 jeffcharles