bytechef icon indicating copy to clipboard operation
bytechef copied to clipboard

Docker deploy with client

Open F1nn-T opened this issue 1 year ago • 3 comments

Description

I added a docker compose file to start the client and the server as one, so users can try out ByteChef without a lot of setup requirements

F1nn-T avatar Aug 06 '24 10:08 F1nn-T

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic Password 80d09968a948df846cb814735925d6bc99e9ee22 deploy/docker/docker-compose.yml View secret
- - Generic Password 80d09968a948df846cb814735925d6bc99e9ee22 deploy/docker/docker-compose.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Aug 06 '24 10:08 gitguardian[bot]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request 🛠 Guidelines to remediate hardcoded secrets 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

These "secrets" are just the default login credentials from the env. Can we ignore that somehow?

F1nn-T avatar Aug 06 '24 11:08 F1nn-T

Hi @F1nn-T thank you for your efforts. I went through changes. Changes in https://github.com/bytechefhq/bytechef/pull/1310/commits/907bf1cbfb3fc93114234e385fa8484f5c2c1930 broke support for qubinets platform - I left couple links at the end. What we do? We use:

  • https://github.com/bytechefhq/bytechef/blob/master/server/apps/server-app/Dockerfile to build base bytechef-server image and publish it at https://hub.docker.com/repository/docker/bitnaprednost/bytechef-server/general
  • https://github.com/bytechefhq/bytechef/blob/master/client/Dockerfile to build server+client and publish it at https://hub.docker.com/repository/docker/bitnaprednost/bytechef-monolith/general

We build from stable repository: https://github.com/bytechefhq/bytechef/tree/stable because it is manually tested.

I understand intention of your change. Provide docker compose for user to test application that doesn't require anything else than just docker-compose run.

Why we haven't provided that? We want to integrate our docker images with scarf analytics: https://docs.scarf.sh/

I'll keep this PR open. We may discuss this at discord.

Qubinets links: platform: https://qubinets.com/ helm-chart-repository: https://gitlab.com/qubes-contributions/qubes-contributions/-/tree/main/apps/bytechef?ref_type=heads

igorbeslic avatar Aug 07 '24 15:08 igorbeslic

Done as part of #964

ivicac avatar Oct 07 '24 08:10 ivicac