egg icon indicating copy to clipboard operation
egg copied to clipboard

"egg-commit-log-edit: Wrong type argument: stringp, nil" when user.name not set

Open LuisFors opened this issue 12 years ago • 0 comments

Attempting to commit when git is not yet configured results in the above error, inside of egg-text.

egg-text has a null check, but since it is a macro, it checks if the function passed to it, (plist-get state :name), is null, when in fact the value it returns is null.

Does egg-text have to be a macro? Can we set a default? (like OS username)

New users are more likely to not have git configured, and are more likely to be stumped by the error message, so I think this is worth fixing.

Same problem occurs when user.email is not set.

LuisFors avatar Nov 17 '13 13:11 LuisFors