faker icon indicating copy to clipboard operation
faker copied to clipboard

boundary tag support increment/decrement from start to end

Open jayeeliu opened this issue 4 years ago • 5 comments

boundary tag support increment/decrement from start to end

jayeeliu avatar Mar 16 '21 07:03 jayeeliu

Codecov Report

Merging #131 (1049531) into master (74585ae) will increase coverage by 0.16%. The diff coverage is 100.00%.

:exclamation: Current head 1049531 differs from pull request most recent head 74689a2. Consider uploading reports for the commit 74689a2 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   92.17%   92.33%   +0.16%     
==========================================
  Files          11       11              
  Lines        1086     1109      +23     
==========================================
+ Hits         1001     1024      +23     
  Misses         46       46              
  Partials       39       39              
Impacted Files Coverage Δ
faker.go 90.66% <100.00%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df4deac...74689a2. Read the comment docs.

codecov[bot] avatar Mar 16 '21 12:03 codecov[bot]

@bxcodec Could you help me to review this pull request ?

jayeeliu avatar Apr 01 '21 03:04 jayeeliu

Hi @jayeeliu, thanks for submitting this PR, by the way, what's the use-case for this PR? Any particular reasons?

bxcodec avatar Apr 04 '21 13:04 bxcodec

@bxcodec To test assignment rules (such as assigning students to teachers according to rules), we need to generate non-repetitive and ordered IDs.

For example, in polling mode, 20 is allocated per round, i need to test assignment process is as follows: 1-20 -> A 21-40 -> B 41-60 -> C 61-80 -> A ...

jayeeliu avatar Apr 06 '21 08:04 jayeeliu

Hi @jayeeliu, we're working on v4 here #169. The biggest change is about options. I think your proposal here is very well suited to the new approach. Can you try to upgrade and follow?

bxcodec avatar Aug 19 '22 15:08 bxcodec