Bartlomiej Plotka comments

Results 932 comments of


                                            Bartlomiej Plotka

A potential goroutine memory leak

As @kakkoyun suggested, we can double check with https://github.com/uber-go/goleak. Help wanted to add this (if not added before) (:

Prometheus Exporter metrics with different tags should have only one HELP and TYPE comment line

👋🏽 Looks like more ppl want to use the new Prometheus endpoint, but can't, due to a broken exposition format implementation. Any updates on this, or at least pointers what...

Avalanche doesn't send remote-write requests when --metric-interval alone is set

We changed a bit of code since you last check. Do you mind double checking if this is still the case?

feat: add config-reloader readiness

LGTM, but we need to resolve the conflicts. Thanks!

Is there any specific reason to not expose now property in the metric options struct?

Thanks! Let's find together a good solution, sorry for breaking your tests. > I am comparing the equality of MetricFamily objects, which include a Counter type metric How you compare...

Rule: Add Grouplabels to Group struct

I went through the history - so the group label is only used on YAML surface - they do not exist on Prometheus internal structs as there is no functionality...

[Design] Dynamic resource usage for GMP operator

+1, some way of handling this would be important, let's prioritize it. VPA/limits is one thing, but perhaps additionally it would be to prioritize the code optimization phase, to check...

summary type metric: pathological performance degradation when observing lots of zeros

Thanks for an extensive investigation! Also saw discussion on [Go performance channel](https://gophers.slack.com/archives/C0VP8EF3R/p1703275787086719), good job! I think it's enough information for us to try to optimize things or at least understand...

Stabilize and extend Parca retention

It's also now just down, we need to stabilize this - use object storage or so to avoid OOMs and have profiles for longer.

Stabilize and extend Parca retention

For context on those who would like to help: ## Use cases for cont. profiling We need continuous profiling, mostly for the retrospective profile storage and to easily access it....