Brian
Brian
@Avantol13 I've addressed all PR items. Please see https://github.com/uc-cdis/indexd/pull/405#discussion_r2369327829 for a followup question.
## Using ContextVar to decouple the web tier from the database driver See https://github.com/ohsu-comp-bio/indexd/blob/672f16b469298d27bb0782627ad1df05ebd65efb/indexd/auth/discovery_context.py ### Why this pattern Current request-scoped values (Bearer token, Arborist resources) are collected in the web...
## Clarification question: How will a web tier decorator will retrieve the `record's authz`? There are several possible database calls, each with their own set of possible parameters. Unclear how...
## API Endpoints Documentation A preliminary list of blueprint endpoints that are impacted by discovery. Ordered by db driver and method. ### indexd/index/drivers/alchemy.py * ids() - Blueprint: indexd.blueprint.indexd - Method:...
```mermaid sequenceDiagram autonumber actor Client participant Flask as Flask App participant Hook as "before_request: ensure_auth_context()" participant Arborist as "Arborist (auth service)" participant Ctx as "ContextVar" participant Repo as "Driver.method()" participant...
Thanks for the thoughtful review, @Avantol13 I’ve aligned the behavior and added a small infrastructure layer to make it reliable and testable. ### What changed (referencing commit `2064504`) * **Discovery...
## Summary of the changes made in commit `0d7f5d706334ff9b5023f4bce39dfb3b7e7b7afd` : A single change was made to a single blueprint method,get_all_index_record_versions, to verify the desired changes. If viable, this pattern would...
# reviewers guide ## Setup Instructions * See [docs/local_dev_environment.md](docs/local_dev_environment.md) for details on setting up a local development environment. ## Testing * See [pytest](https://github.com/uc-cdis/indexd?tab=readme-ov-file#testing) * Suggest doing this on master first...
> # Feature Request ⚙️ @lbeckman314 Can you remove the comment above re. the use case document? The request is here: See updated https://docs.google.com/document/d/1tHFyI-s8N8DccJYnbfxo-hBgOrULms7DMOAmXtqhNeA/edit?usp=drive_web&ouid=110793006573203727769
Update 💥 * removed extraneous DEBUG logging * moved rbac enforcement to alchemy driver