sso icon indicating copy to clipboard operation
sso copied to clipboard

*: combine sso-{auth,proxy} into a single binary

Open namliz opened this issue 7 years ago • 3 comments

I'm still reading through but it seems like it wouldn't be too hard to roll sso-auth and sso-proxy into a single binary, busybox/minikube style.

It would simplify deployment, I think the benefits are worth the effort.

namliz avatar Oct 05 '18 20:10 namliz

I'm curious, is there any specific reason to have two different binaries? or is this just a legacy thing?

snebel29 avatar Oct 15 '18 20:10 snebel29

@snebel29 This project is a fork/continuation of bitly/oauth2_proxy. I'm guessing during the prototyping phase the idea of the double redirect came about and it was easier to try it with two binaries.

There's no advantage to it as far as I can tell, I'm tinkering with folding it back in my spare time.

namliz avatar Oct 16 '18 03:10 namliz

@zilman is correct -- this is more an artifact of how we went about development and primarily just legacy. We've thought about trying to roll the project into a single binary and haven't gotten around to investigation/implementation.

jphines avatar Oct 16 '18 13:10 jphines