sso icon indicating copy to clipboard operation
sso copied to clipboard

sso-proxy: remove provider interface

Open shrayolacrayon opened this issue 7 years ago • 3 comments

What

This is something that was not changed from the original oauth_proxy clone that can be removed. Since we only have one provider for sso-proxy - the SSOProvider, to simplify testing and remove default provider logic, it makes sense to get rid of the interface and have the OAuthProxy struct's provider field be an SSOProvider rather than a Provider interface.

shrayolacrayon avatar Oct 04 '18 23:10 shrayolacrayon

won't this block #27 ?

luisdavim avatar Oct 18 '18 09:10 luisdavim

This is specifically to remove the provider interface (or consolidate both provider interfaces into one) in sso-proxy. This was something that we have yet to clean up from when we began development from starting off with using oauth2_proxy. sso-proxy's only provider is sso-auth and sso-auth uses a third party authenticator defined by a provider interface. https://github.com/buzzfeed/sso/issues/27 refers to sso-auth's third-party providers.

shrayolacrayon avatar Oct 22 '18 21:10 shrayolacrayon

Makes sense, thanks for explaining that.

luisdavim avatar Oct 22 '18 23:10 luisdavim