Markus Rudy
Markus Rudy
This is good to go as far as I'm concerned. Please let me know until 2024-05-21 if you'd like to see modifications.
It's been some time since this PR was opened and I don't think we have any performance issues due to wrong MTU settings on GCP anymore. There may have been...
This should be good to review now, I'll add a Github Action later on.
@nicmue could you please take a look at this PR, with particular attention to module structure, Rust best practices and the test implementation? I wonder if there's a better way...
@nicmue Thanks so much for the review, and sorry for taking some time to get back to it. This was really helpful, and now I know about `clippy` (and `check`,...
@nicmue since you are now co-author here, do you want to sign Google's CLA? Alternatively, I can remove the `Co-authored-by` lines from the commits if you'd prefer.
The CLA bot check failure has some info: https://github.com/google/glome/pull/175/checks?check_run_id=26263501184. tl;dr: sign in to https://cla.developers.google.com/clas and agree to the terms.
2024 update: * Public keys at rest have a specified format according to RFD002. * Private keys are still 32 raw bytes. Storing them as [PKCS #8](https://en.wikipedia.org/wiki/PKCS_8) would allow standard...
Note: in its current form, this change breaks integration with Kubernetes device plugins. I'm looking for ways to allow those, probably via the settings, but would appreciate feedback on the...
The settings file is now considered when allowlisting devices.