bundlewrap icon indicating copy to clipboard operation
bundlewrap copied to clipboard

`bw verify` should check `unless` conditions of `action` items

Open fkusei opened this issue 3 years ago • 1 comments

I just did a bw verify against one node, which didn't show any pending changes. However, when doing an bw apply -i, it prompted me to run an action, because its unless failed.

bw verify should run unless to show the user which actions would be executed.

fkusei avatar Mar 24 '22 06:03 fkusei

It should be safe to implement this, because the docs say:

The commands you choose for unless should not change the state of your node. Otherwise, running bw verify might unexpectedly interfere with your nodes.

However, we do have at least two places in our repo where we break this assumption.

Changing this could be surprising for users. Should probably be done in 5.0. 🤔

vain avatar Mar 03 '25 07:03 vain