samples icon indicating copy to clipboard operation
samples copied to clipboard

Create sample apps with dockerfiles, hooks, etc

Open aemengo opened this issue 4 years ago • 5 comments

In light of https://github.com/buildpacks/rfcs/pull/173, sample applications should be created with these new buildpack constructs: App Specified Dockerfile, Hook TOML, etc.

aemengo avatar Oct 07 '21 20:10 aemengo

Is the following builder structure correct ?

Screenshot 2021-10-08 at 17 15 56

@sclevine @natalieparellano @aemengo

cmoulliard avatar Oct 08 '21 15:10 cmoulliard

I think ext.toml should be extension.toml. I don't think build.ext.toml and launch.ext.toml are included in the RFC (they were just talked about).

natalieparellano avatar Oct 08 '21 16:10 natalieparellano

Please see https://github.com/buildpacks/lifecycle/issues/709#issuecomment-938746662 for an initial take on this issue.

natalieparellano avatar Oct 08 '21 16:10 natalieparellano

(they were just talked about).

I saw them from a comment of Javier Romero. will remove them and add also run.Dockerfile and build.Dockerfile

cmoulliard avatar Oct 08 '21 16:10 cmoulliard

Structure updated

Screenshot 2021-10-08 at 18 24 34

cmoulliard avatar Oct 08 '21 16:10 cmoulliard