pack icon indicating copy to clipboard operation
pack copied to clipboard

Add a new `manifest` command to support multi-architecture builds

Open husni-faiz opened this issue 3 years ago • 1 comments

Hi all,

Multi-architecture support for buildpacks have been requested (#1459 | #1460 ) for a long time. Recently I have been working on this as part of the Linux Foundation Mentorship program under the mentorship of Juan Bustamante (@jjbustamante), Jerico Pena (@jericop) and Aidan Delaney (@AidanDelaney)

We would appreciate your ideas and thoughts on how we want to move forward. There is a lot of validations and test to be added along the line. We are having a weekly meetings for multi-arch support every Monday @ 10:00 AM EDT/EST. You can find the zoom link in the meeting minutes document.

A new ImageIndex/ManifestList interface is being added to imgutil module.

You may find the following resources useful.

Fixes #1678 Fixes #1460 Fixes #1722 Fixes #1720 Fixes #1721 Fixes #1719 Fixes #1718

husni-faiz avatar Apr 05 '23 14:04 husni-faiz

Moving to milestone 0.31.0

jjbustamante avatar Jun 07 '23 20:06 jjbustamante

@jjbustamante there was an issue with pack buildpack package when packaging local buildpacks without --publish flag. Please make sure the issue is resolved before merging this PR. The issue is there is a panic when we building local buildpacks, the program panics here

ep0ll avatar Apr 25 '24 04:04 ep0ll

@jjbustamante there was an issue with pack buildpack package when packaging local buildpacks without --publish flag. Please make sure the issue is resolved before merging this PR. The issue is there is a panic when we building local buildpacks, the program panics here

On this branch?

jjbustamante avatar Apr 25 '24 22:04 jjbustamante

@natalieparellano there are still some work to do, but the branch is compiling I played a little bit with the commands locally, let's just give it the last push, polish it a little bit more together with the imgutil PR and let's get this thing done!

jjbustamante avatar Apr 26 '24 21:04 jjbustamante

Great work @husni-faiz @jjbustamante :) I left a few code suggestions and a few comments, but the only ones that are truly blocking for me are

Edit: on the last comment, I think that is actually what we are doing. I'll leave a code suggestion...

natalieparellano avatar May 01 '24 15:05 natalieparellano

@natalieparellano Thanks a lot for the feedback

I just refactored the files

I changed it for oci or docker default value is oci

Yeah, I think what is missing here is to add some validation to accept --insecure when --publish flag is used.

jjbustamante avatar May 02 '24 15:05 jjbustamante