feedback icon indicating copy to clipboard operation
feedback copied to clipboard

Feature: prevent cancel

Open joscha opened this issue 7 years ago • 6 comments

Any chance to get an option cancelable: true|false, disabling the "Cancel" button in the web UI?

joscha avatar May 02 '18 23:05 joscha

We'll discuss, interested to know a bit more about what you'd use this for!

lox avatar May 03 '18 05:05 lox

We have a step that is changing infrastructure - it has a rollback/cleanup mechanism at the end if something went wrong. This rollback is never executed if the job gets cancelled, so we do this:

poor man's do not cancel

I named the image poor man's do not cancel, we would like to...improve this for obvious reasons.

joscha avatar May 03 '18 05:05 joscha

One place this would be useful is in tandem with "cancel intermediate builds". We'd like to cancel pending deploys, but not interrupt running deploys.

jellevandenhooff avatar May 10 '18 21:05 jellevandenhooff

This would be a huge help for us too regarding the cancel intermediate builds! The issue is when someone deploys a branch, they would need to remember not to push to their branch until the deploy is complete, otherwise it would be cancelled. Some deploys take a long time, so we cant use this feature.

enkoder avatar Aug 09 '18 21:08 enkoder

+1 - for the same reasons as above!

leighst-anchorage avatar Jan 23 '22 22:01 leighst-anchorage

We'd also benefit from the concept of an non-cancelable step. Basically the same reason. If a developer cancels a build when a specific step is running, we get state-locks in pulumi.

But it would be nice to be able to cancel a build; and wait for the non-cancelable steps to finish

mrjackdavis avatar Feb 09 '23 23:02 mrjackdavis