agent icon indicating copy to clipboard operation
agent copied to clipboard

allow custom git clone flags during a plugin checkout

Open scriptnull opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? Please describe. In all our jobs, the first thing to be executed is the "Preparing plugins" section which clones the git repos of plugins that we use for that step.

But the git clone of a plugin repo is adding a lot of log lines (to report the progress of the clone) which often adds noise to our build logs. We would ideally like to suppress these logs by doing a git clone --quiet instead.

Describe the solution you'd like I would like to add a new config to the agent - something like plguins-git-clone-flags (BUILDKITE_PLUGINS_GIT_CLONE_FLAGS) and make use of that config while cloning the plugin repo here: https://github.com/buildkite/agent/blob/79a7ba7c5045ea30ce009ba80d6eed47fe578ed1/bootstrap/bootstrap.go#L899-L916

Describe alternatives you've considered None

Additional context This is how our build logs look when the plugin is cloned for the first time. (a sample of first few lines, but imagine 500+ more lines like this) image

Having this config option would help is in avoiding these lines in our build logs.

scriptnull avatar Nov 18 '22 05:11 scriptnull

I am willing to open a pull request for this if someone from the buildkite team could tell me if it is okay to add the above-proposed config option :slightly_smiling_face:

scriptnull avatar Nov 18 '22 05:11 scriptnull