[Bug Report] buildkite artifact download (v3) seems not respect --include-retried-jobs when --step is provided

[fa93hws]

Hi, I am working on a feature works on a retry job and artifact from the job before the retry need to be fetched.

agent artifact download foo bar failes, but buildkite-agent artifact download foo bar --include-retried-jobs works, so I assumes by default it would not download matched artifact from a failed job?

Then --step is added because, but agent artifact download foo bar --step step_key --include-retried-jobs fails with

No artifacts found for downloading

While agent artifact download foo bar --step step_label --include-retried-jobs fails with

404 A step could not be found matching: job_label

So I assumes --step should accept step key, otherwise it should give 404. But it seems that when --job is provided, --include-retried-jobs isn't respected properly so that artifacts from the failed job can't be found?

[pda]

Thanks for the report @fa93hws.

So it sounds like specifying a --step stops --include-retried-jobs from working.

@moskyb and I have taken a look at the server-side search code and it looks like it should be working, but clearly it isn't, so we'll schedule some time to look into this.

[pda]

(To be clear, this is probably a server-side Artifact Search bug, not something that can be fixed in the agent itself)