Oliver Lillie

Results 41 comments of Oliver Lillie

No worries, glad to help, but I'm not entirely sure of what you mean?

Did you manage to sort this out? Was there an error in the algorithm? It looks as if the wrong dimension is being used to calculate the optimum size.

If you create a pull request I will merge.

I'm also getting the exact same issue with 6.3.8 too and webpack 4 ``` ERR! TypeError: (intermediate value) is not iterable ERR! at _default (xxxx/build/.yarn/$$virtual/@storybook-builder-webpack4-virtual-058dc2c569/0/cache/@storybook-builder-webpack4-npm-6.4.20-5e50c2b126-de8f34a022.zip/node_modules/@storybook/builder-webpack4/dist/cjs/preview/iframe-webpack.config.js:73:22) ERR! at processTicksAndRejections (node:internal/process/task_queues:93:5) ERR!...

This seems to be stemming from when the presets returned from this https://github.com/storybookjs/storybook/blob/next/lib/builder-webpack5/src/preview/iframe-webpack.config.ts#L79 returns an empty object `{}` instead of an empty array

Yes, however you don't need it if you set an "until" rule. However the patch is as follows ``` php // impose a upper ceiling. if(isset($this->rules['until']) === false) { $this->rules['until']...

Has this been reconsidered yet?

@y-lohse Did you ever get round to porting your code over to the latest release?

Seems like this is a bug within firefox itself, or at least the intended functionality of scrolling horizontally with the wheel event in firefox. Take this http://jsfiddle.net/buggedcom/mr4xn2r1/ for example. In...