Robert J. Lang
Robert J. Lang
> It is correct to use the value returned by get_t() when $phase is equal to 'install', which happens when a module is going to be installed. That's true, but...
Thanks, @kiamlaluno for the clarification and explanation. `$t` is now restored to `simpletest_requirements()`.
@klonos, your PR comments are (I hope sufficiently) addressed in the revised PR. Check again?
Interesting. Meanwhile, we can here do what I've done with Ubercart's curl checks: use a module-specific key (`simpletest_curl`) in modules that talk about the same topic.
There are now two entries for "cURL", with the error one from Simpletest at the top. I think that's appropriate.
Even without https://github.com/backdrop/backdrop-issues/issues/6241, I think that giving Simpletest its own unique `hook_requirements()` key, as above (and in the current PR) is a perfectly acceptable solution. Yes, there would be two...
If the function was previously implicitly `public`, then it would seem that when visibility is made explicit, it should also be `public` in the interest of backward compatibility. Some functions...
Getting CSpell to the point where it is adding more value than "crying wolf" has been a great accomplishment, and I wholeheartedly support the continued cleanup. It seems, then, that...
In looking for issues that are "nearly there," I see this one needing only code review (according to its labels). But there are two PRs, https://github.com/backdrop/backdrop/pull/2916 (managed files only) and...
It's because that icon is a FontAwesome character. In the old theme, FontAwesome was included in function `borg_preprocess_page()`: ```php // Add FontAwesome. backdrop_add_js('https://use.fontawesome.com/baf3c35582.js', array('type' => 'external')); ``` But in the...