vscode-buf icon indicating copy to clipboard operation
vscode-buf copied to clipboard

[WIP] Add language server support

Open amckinney opened this issue 3 years ago • 3 comments

This adds support for the recently released https://github.com/bufbuild/buf-language-server.

This is based on the VSCode Language Extension Guide and the sample language server client implementation.

amckinney avatar Aug 17 '22 20:08 amckinney

All of the build errors originate from node_modules/vscode-languageclient/..., but we exclude node_modules in tsconfig.json- there's probably something small we need to adjust here.

amckinney avatar Aug 17 '22 20:08 amckinney

The build errors stem from tsc validating the types in dependencies with the compiler option strict: true. The package vscode-languageclient was written against @types/vscode v1.67.0, but we install v1.63.0.

The immediate issue is fixed with npm i @types/[email protected], but we might want to look into moving away from the deprecated vscode-test package long term.

timostamm avatar Aug 18 '22 10:08 timostamm

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 29 '23 00:04 CLAassistant

Is this PR still alive ? From vscode-proto3 to buf , the go to definition is broken .

scbizu avatar Jul 12 '24 02:07 scbizu

No, the language server at https://github.com/bufbuild/buf-language-server is not being actively developed so this PR isn't going to get merged.

nicksnyder avatar Jul 12 '24 13:07 nicksnyder