plugins icon indicating copy to clipboard operation
plugins copied to clipboard

Plugin request for protoc-gen-go_{cli,gapic}

Open mfridman opened this issue 1 year ago • 2 comments

Mandatory

Where is the source code for the plugin?

https://github.com/googleapis/gapic-generator-go/tree/main/cmd

Optional

Does the plugin have a valid semver version?

Yes.

https://github.com/googleapis/gapic-generator-go/releases

Latest as of this writing is v0.43.1.

Does the plugin have a dependency on another plugin?

Not sure.

Does the output of this plugin depend on any other external libraries?

Not sure.

mfridman avatar Jun 18 '24 19:06 mfridman

Doesn't this plugin function by reading local disk if I remember? If so, we can't add it as of now, can you confirm @mfridman ?

bufdev avatar Jun 26 '24 18:06 bufdev

They made some significant changes in that project, I took a quick peek and most of the os calls are gated by an option. For example,

https://github.com/googleapis/gapic-generator-go/blob/134f862b5a05028c5e1af4b55ad213bf6ce9757d/internal/gengapic/generator.go#L137-L141

I'll timebox this and see if I can get a simple project to work without local disk.

TL; DR - Both plugins might work.

mfridman avatar Jul 05 '24 19:07 mfridman