buehler
Feature/conversionwebhook
I have implemented the feature to create conversion webhooks to resolve #137 As part of this implementation i have created integration tests. There must be a running Kubernetes cluster to run these integration tests. It would be possible to run these tests in a pipeline but that would probably cost money because of the Kubernetes cluster that is mandetory.
I also had to change the usage of AddWebhookLocaltunnel because i ran into a problem where the reconcile of a given custom resource stops when the custom resource definition gets updated in the creation of the Localtunnel. Thats why i thought it would be a good idea to wait for the LocalTunnel to be created before starting the controllers. I made this possible by changing the way you add the localtunnel.
Instead of
services.AddKubernetesOperator().AddWebhookLocaltunnel();
you simple use
services.AddKubernetesOperator(s => settings.UseLocalTunnel());
I'm really curious what you think about the implementation of this feature
I understand that this is a pretty big pull request so take your time and dont hesitate to ask me any questions for clarification
First of all: thank you !
I'll review the PR as soon as I have some spare time. The local tunnel change results in a breaking change, therefore I'll merge this PR into the next branch where we already have some breaking changes. For the integration tests: this is not an issue, we can start a minikube instance in GitHub Actions, just describe what you'll need and I can provide a GitHub action for it.
Hey @odinvanderlinden
I started the review and it is huge :-) There are quite some breaking changes in this PR. I am not certain if I can merge this branch into the master. Would you mind, if I take the general idea of your PR and implement them into the current code?
I would not mind it if you take the idea and implement it into the current code. If you do so, i would like to review your implementation of the conversion webhook because most of these braking changes had a reason. I'm looking forward to see what you make out of it!