Improving file eviction performance
@mostynb, what do you think about this?
Is anything more needed from me to land it?
I can add test cases if you are OK with the overall approach.
Friendly reminder. @mostynb , do you know when you might have time to consider this?
Sorry for the delay, I will take a look this week.
Thanks for your comments @mostynb! I now uploaded an additional commit (https://github.com/buchgr/bazel-remote/pull/696/commits/ee7e48f1dc14f2f7897066ffc8a468ee88fb9d9b) to this PR, containing updates according to your comments and with added unit tests. In addition it also fixes some issues related to de-inline and also related to propagation of http.StatusInsufficientStorage.
Tuesday next week (24th of June) will be my last day before I go on vacation. Is there anything you'd like me to do before then? Otherwise, I’ll be back in the middle of August.
Feel free to land or make changes to the PR @mostynb if you prefer while I’m away.
Tuesday next week (24th of June) will be my last day before I go on vacation. Is there anything you'd like me to do before then? Otherwise, I’ll be back in the middle of August.
Feel free to land or make changes to the PR @mostynb if you prefer while I’m away.
I am hoping to do a release before we land this, since there's an important bug fix. I will try to land this soon afterwards- thanks for persevering all this time, and enjoy your vacation.
A version of this has landed on the master branch.
I'm back from vacation now. Huge thanks for landing this, @mostynb! :smile:
This is included in v2.6.0.