btcd icon indicating copy to clipboard operation
btcd copied to clipboard
verified publisher icon btcsuite

mining: return witness_script instead of raw witness_commitment in GBT

Open roylee17 opened this issue 4 years ago • 4 comments

The "default_witness_commit" in the getblocktemplate response uses the witness_script instead of raw commitment.

roylee17 avatar Feb 08 '22 07:02 roylee17

Pull Request Test Coverage Report for Build 1850844731

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.676%
Totals Coverage Status
Change from base Build 1808348675: 0.0%
Covered Lines: 1231
Relevant Lines: 1545
💛 - Coveralls

coveralls avatar Feb 08 '22 07:02 coveralls

@Roasbeef

roylee17 avatar Feb 09 '22 00:02 roylee17

@roylee17 slipped by initial due to a lack of integration tests in this area. Would you mind adding a new test in the integration folder? It would use GBT to construct a new block and then assert that we also accept that same block.

Roasbeef avatar Feb 15 '22 23:02 Roasbeef

[Accidentally deleted the branch, which generates the, PR.]

@Roasbeef I'll look into how to create that test.

roylee17 avatar Feb 16 '22 04:02 roylee17