sql-indent icon indicating copy to clipboard operation
sql-indent copied to clipboard

Merged my 'advice' to upstream.

Open yangyingchao opened this issue 8 years ago • 3 comments

I use sql-indent on my work, and sometimes sql-indent does not work as I expected, for example:

  1. Indentation does not work for some keywords by default:

    BEGIN, ELSE, END, DELIMITER and so on.

  2. "TAB" behaves differently compared to other modes when cursor in placed at beginning of line:

    it indents code but does not move cursor accordingly. Suppose I move cursor to the beginning of next line which is empty, and then I want to stroke TAB to move cursor to correct indentation before typing SQL statements, it does nothing. I have to type something, and then stroke TAB to make it work.

    This is different compared to all other modes.

I use several `advice' to make sql-indent work as I expected, but it would be great if this could be done internally in sql-indent package.

Thanks.

yangyingchao avatar Mar 08 '17 01:03 yangyingchao

Thank you.

Can you please fix this so that the tests still pass?

bsvingen avatar Mar 16 '17 02:03 bsvingen

sure, will do it when I have time. :)

在 2017年3月16日,上午10:45,Børge Svingen [email protected] 写道:

Thank you.

Can you please fix this so that the tests still pass?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bsvingen/sql-indent/pull/5#issuecomment-286942124, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8ceZy6f01gPKHqqrAkYIK4Ov5c7aweks5rmKJagaJpZM4MWRTb.

yangyingchao avatar Mar 16 '17 02:03 yangyingchao

Sorry that I failed to setup testing environment, so can't fix the tests..

I put my changes along with David's pull request in this file: https://github.com/yangyingchao/tubo-env/blob/master/.emacs.d/site-lisp/utils/sql-indent-mode.el.

yangyingchao avatar Mar 19 '17 02:03 yangyingchao