python-mingus icon indicating copy to clipboard operation
python-mingus copied to clipboard

Add missing entries for '7sus4', 'add11', 'add13', 'add9' to chord_shorthand

Open yaph opened this issue 4 years ago • 3 comments

A call like from_shorthand('C7sus4') resulted in an "Unknown shorthand" error. I noticed that some other entries in chord_shorthand_meaning were not present in chord_shorthand so I added these as well.

To run make test I had to install numpy.

The following call still results in an error, but I don't know the code well enough to make it work:

from_shorthand('C9b5')

yaph avatar Dec 17 '21 01:12 yaph

Nice work

BonifacioCalindoro avatar Dec 27 '21 15:12 BonifacioCalindoro

I think 11 and add11 are different: add11 has an added 11th without the 7th and 9th Same problem with add13

ldrolez avatar Aug 08 '23 13:08 ldrolez

I think 11 and add11 are different: add11 has an added 11th without the 7th and 9th Same problem with add13

Exactly, those chords imply different notes. That difference is necessary for the robustness of modern harmony

BonifacioCalindoro avatar Aug 08 '23 13:08 BonifacioCalindoro