Bård Skaflestad

jenkins build this please

Would you mind adding a unit test for this keyword, please? Preferably one that demonstrates each of the following cases 1. Single PVT region, 2 records 2. Single PVT region,...

One more comment. We [already have a `UnitSystem`](https://github.com/OPM/opm-common/blob/144faaf6456cf646f5dedab2a1089f240e9f63bb/src/opm/output/eclipse/WriteInit.cpp#L627) object in `InitIO::write()` and that one is supposed to be the same as—or at least equivalent to—the one stored in the `FieldProps`...

> The one I points to is the one used for in put I believe. That is true, but so is [the one in `InitIO::write()`](https://github.com/OPM/opm-common/blob/144faaf6456cf646f5dedab2a1089f240e9f63bb/src/opm/output/eclipse/WriteInit.cpp#L627).

> As a bonus we avoid the need to have explicit ctors, copy ctors, assignment and comparison operators. :tada:

> sadly it seems the variant approach is significantly slower That's disappointing.

> * GCC 8.2.0 Do you have a way of testing GCC 9.x or later? This **may** be a compiler error or missing feature in GCC 8.x and/or a problem...

> with the following changes: Hm, weird. Did you have to `#include ` twice? The original `k.hpp` did include that header...

> What also confuses me a bit is, that when the compilation fails and I rerun the command that failed: > > ``` > /cluster/spack/apps/linux-centos7-x86_64/gcc-4.8.5/gcc-8.2.0-6xqov2fhvbmehix42slain67vprec3fs/bin/g++ \ > -DBOOST_ALL_NO_LIB \ >...

> I believe item 1 (SALTSOL) should have units of Salinity (LB/STB) rather than density (LB/FT3) to be consistent with e.g. SALTVD. Possibly. I seem to recall that there was...