bryphe

Results 160 comments of bryphe

Also, in theory, this test should be catching stuff like this: https://github.com/onivim/oni/blob/master/test/ci/Neovim.InvalidInitVimHandlingTest.ts

One other detail - @CrossR mentioned his config works fine on Windows, and this issue does not repro. So it could be an OSX-only issue, although @CrossR has some pieces...

Thanks for the details, @appelgriebsch ! @CrossR saw it might be related to this issue: https://github.com/neovim/neovim/issues/8524

We should have our CI build test against earlier OSX versions to help guard against this in the future - https://docs.travis-ci.com/user/reference/osx/#OS-X-Version

Downgrading to `0.2.2` sounds like the safest approach for now! I see two next steps here: 1) Set up our Mac builds so that we test against an earlier Mac...

I'm able to reproduce this now after upgrading to mojave. Trying to track this down, a few observations: - Running Oni from the command line (`open Oni.app`) works - Running...

Finally found the issue with mojave - it's related to this Neovim issue: https://github.com/neovim/neovim/commit/57acfceabeb349377ce244de9b67732b21ed1d18 It seems that the `LANG` environment variable isn't provided by default when launching from `Finder` in...

We actually have an API (internal) to support this - we can register `KeyResolvers` which are a function that take the `KeyboardEvent` and return a `string`. They live here today:...

The user config would be a fine place to try this out, but I could see bringing this in as core functionality too (gated by a config, like `tmux`). In...

I don't have an actual Apple keyboard to test, but I believe the `command` key on Apple maps to `meta`. There isn't a concept of recursion with the input resolvers,...