support icon indicating copy to clipboard operation
support copied to clipboard

RecurrenceConfirmationPopup reconfiguration should be easy

Open ExtAnimal opened this issue 1 year ago • 0 comments

Forum post

The recurrenceConfirmationPopup config in Scheduler mixin Recurring events should be made public. It is used by drag/drop.

The RecurringEventEdit.js mixin of EventEdit should consult that config from its client when creating its own instance in addition to honouring its own recurrenceConfirmation property (That should be renamed to recurrenceConfirmationPopup, be promoted to be a configurable and made public.:

Screenshot 2024-06-13 at 16 39 42

In CalendarDrag, RecurremceConfirmationPopup instances leak because one is instantiated on every drag of an occurrence.

It needs to create only one, and pull in the recurrenceConfirmationPopup property from the client Calendar. Calendar then requires a recurrenceConfirmationPopup config.

SchedulerPro

SchedulerPro TaskEditorBase.js has

            recurrenceConfirmation = Widget.create({
                type  : 'recurrenceconfirmation',
                owner : me
                // <remove-on-release>
                // TODO: configurability?
                // ...recurrenceConfirmation
                // </remove-on-release>
            });

It should do the same. It should pull in this.client.recurrenceConfirmationPopup.initialConfig to configure the confirmation. As it stands now, it is unreconfigurable. It also leaks instances because a new one is created each time!

ExtAnimal avatar Jun 13 '24 14:06 ExtAnimal