http-browserify icon indicating copy to clipboard operation
http-browserify copied to clipboard
verified publisher icon browserify

replace params.scheme with params.protocol

Open hendrikcech opened this issue 11 years ago • 2 comments

When passing an url string to https-browserify, a http request was send off. This commit simplifies the code and fixes that bug.

hendrikcech avatar Feb 15 '14 01:02 hendrikcech

this looks like it actually complicates the code - what bug does this fix? Probably should add a test to exercise it

tmpvar avatar Sep 24 '14 16:09 tmpvar

It needs to be more complicate to be backwards compatible. This change is necessary to be consistent with the node api. It's also connected to this bug: substack/https-browserify#1.

hendrikcech avatar Sep 24 '14 17:09 hendrikcech