detective icon indicating copy to clipboard operation
detective copied to clipboard
verified publisher icon browserify

fix(package): [email protected]

Open aaditkamat opened this issue 3 years ago • 6 comments

Closes https://github.com/browserify/detective/issues/88

aaditkamat avatar Feb 24 '22 00:02 aaditkamat

@bcomnes @goto-bus-stop Can we merge this? Thanks

avanelli avatar Aug 25 '22 15:08 avanelli

I believe this wasn't done yet because acorn-node@2 broke compatibility with some old node.js version. I'd like to fix that at some point (the point of acorn-node is to support new syntax as widely as possible, including on abandoned node.js versions) and then we can publish this too.

goto-bus-stop avatar Oct 17 '22 15:10 goto-bus-stop

@goto-bus-stop Heya! Is the acorn-node@2 compatibility issue still a concern? Would be great to have a newer release of detective and browserify in order to get support for the Node.js v15 logical assignment operators!

rnegron avatar Feb 08 '23 18:02 rnegron

@goto-bus-stop How old are we talking? The PR here seems to run fine down to Node.js v8 (which is itself EoL since 2019_ and I can't imagine supporting older than that can be a priority anymore?

https://github.com/legobeat/detective/actions/runs/6067551505/job/16459360769?pr=2

legobeat avatar Sep 04 '23 00:09 legobeat

@bcomnes @goto-bus-stop 👋🏻 Bumping this to ask if this is something that's still on your radar!

rnegron avatar Jan 30 '24 14:01 rnegron

So sorry, I haven't been working with browserify in a few years and don't have enough context as to what even the right move to make here is without having to research it.

bcomnes avatar Jan 31 '24 00:01 bcomnes