code.pyret.org add pinhole support to place-image-align, and change add-line to work from the top-left corner

We don't yet have any test cases that notice this change; I ran it manually on one example so far. I'll try to add some more test cases soon.

Feb 14 '25 04:02 blerner

@dbp is this obsoleted by your https://github.com/brownplt/pyret-lang/pull/1802 ? I think the place-image-align part is still useful, but your change for add-line is different from this one...

Aug 24 '25 17:08 blerner

@dbp checking in about Ben's comment here.

Nov 18 '25 13:11 schanzer

I think the pinhole support is missing from the other PR? But regardless, this particular CPO PR is obsolete because the image library has moved to pyret-lang. @dbp can you confirm where both parts of your improvements are, and whether we've fixed the crashing bug in your other PR? And do we have tests for this so we can merge it?

Nov 18 '25 21:11 blerner

IIRC, when I changed add-line, I didn't change some other functions that were nearby, that seemed like maybe they could use refactoring, as they were implemented very differently (but, one upside meant that they didn't have the bug that add-line had). As far as I know, the bug that @jpolitz saw for command-line node-canvas still exists (unless he fixed it)?

I did not add automated test cases in that PR (not sure the workflow for doing that with image stuff? Do existing image tests test pixel output? Or compare for equality for different operations? Or?).

Not quite sure what I'm being asked here -- I do not know this code well :)

Nov 19 '25 01:11 dbp