gitx icon indicating copy to clipboard operation
gitx copied to clipboard

Minor tweaks to commit line drawing

Open lilyball opened this issue 15 years ago • 2 comments

The first commit is unambiguously correct. It cleans up the column guide drawing code to draw the line more accurately (instead of 5 pixels off, as it is right now) and to stop relying on the dirty rect as part of its positioning code.

The second commit is something that I really like. It adds the ability to have two separate column guides, one for the first line and one for all subsequent lines. Right now this is kept as a hidden preference that defaults to off, but if accepted then it should be added to the preferences window.

lilyball avatar Nov 09 '10 23:11 lilyball

Hrm, apparently pushing a new commit automatically adds it to the existing pull request. That's kinda neat, but also unexpected.

lilyball avatar Nov 10 '10 00:11 lilyball

Looks like you pulled in the first commit at some point. Any chance of pulling in the second? I still needs an actual GUI preference, but I don't see why that has to hold up adding the functionality. I've had to distribute my custom build of GitX to everyone in the office instead of letting them download yours because of this.

lilyball avatar Dec 09 '10 22:12 lilyball