flex-mouse-grid icon indicating copy to clipboard operation
flex-mouse-grid copied to clipboard

Close the canvas when the grid is not shown on screen

Open BlueDrink9 opened this issue 9 months ago • 3 comments

fixes #11

BlueDrink9 avatar Jul 29 '25 22:07 BlueDrink9

Hi @BlueDrink9, thanks for the PR. I'm noticing that the boxes command no longer works with this change, unless the flex grid is already showing, so that's a deal breaker.

I'm not maintaining this very actively, so I leave it to you to find the fix there. Or, you can always just continue to use this branch locally.

brollin avatar Jul 30 '25 03:07 brollin

Good catch, I don't normally use that command. I will see if I can fix it! Should probably also check a points, I suppose.

BlueDrink9 avatar Jul 30 '25 03:07 BlueDrink9

I have fixed that and tested that it works on multiple screens and that points also works.

There is a whole bunch of refactoring that I could do, I'm thinking mainly of just reducing a lot of the replicated code for now, similar to the one that I have included about the visibility flags. How fussy are you about a very clean git history and small pull requests? Would you be happy for me to keep going and include those in this?

BlueDrink9 avatar Jul 31 '25 04:07 BlueDrink9